docs: update chain IDs for bundlerChain #7046
Conversation
Summary of ChangesHello @chenjiahan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity and completeness of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the documentation for bundlerChain by expanding the list of ONE_OF chain IDs and clarifying their usage as branches under main rule types. The changes are well-organized and make the documentation more accurate and easier to understand. I've found a minor typo in both the English and Chinese documentation that I've flagged for correction.
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation for bundler chain IDs to reflect the new oneOf structure introduced in PR #7037. The documentation now includes comprehensive listings of ONE_OF chain IDs for JS, CSS, Less, Sass, Stylus, and SVG processing branches.
Changes:
- Reorganized RULE entries to group plugin-dependent rules (LESS, SASS, STYLUS) together with their plugin requirements noted
- Expanded ONE_OF section to document all branch IDs for JS, CSS, and preprocessor rules (Less, Sass, Stylus)
- Added clarifying text explaining that ONE_OF entries are branches within rules, not top-level rules
- Updated SVG-related ONE_OF descriptions for better clarity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/docs/en/config/tools/bundler-chain.mdx | Updated English documentation with reorganized RULE entries and expanded ONE_OF chain IDs |
| website/docs/zh/config/tools/bundler-chain.mdx | Updated Chinese documentation with reorganized RULE entries and expanded ONE_OF chain IDs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | `ONE_OF.STYLUS_INLINE` | `?inline` branch under `RULE.STYLUS` | | ||
| | `ONE_OF.SVG_URL` | SVG branch for emitting a separate file | | ||
| | `ONE_OF.SVG_INLINE` | SVG branch for inlining as data URI | | ||
| | `ONE_OF.SVG_ASSETS` | SVG branch for auto selection between data URI and file | |
There was a problem hiding this comment.
The constant name should be ONE_OF.SVG_ASSET (singular) not ONE_OF.SVG_ASSETS (plural). According to the source code in packages/core/src/configChain.ts line 91, it is defined as SVG_ASSET: 'svg-asset'.
| | `ONE_OF.SVG_ASSETS` | SVG branch for auto selection between data URI and file | | |
| | `ONE_OF.SVG_ASSET` | SVG branch for auto selection between data URI and file | |
| | `ONE_OF.STYLUS_INLINE` | `RULE.STYLUS` 下的 `?inline` 分支 | | ||
| | `ONE_OF.SVG_URL` | SVG 输出为独立文件的分支 | | ||
| | `ONE_OF.SVG_INLINE` | SVG 内联为 data URI 的分支 | | ||
| | `ONE_OF.SVG_ASSETS` | SVG 在 data URI 与独立文件之间自动选择的分支 | |
There was a problem hiding this comment.
The constant name should be ONE_OF.SVG_ASSET (singular) not ONE_OF.SVG_ASSETS (plural). According to the source code in packages/core/src/configChain.ts line 91, it is defined as SVG_ASSET: 'svg-asset'.
| | `ONE_OF.SVG_ASSETS` | SVG 在 data URI 与独立文件之间自动选择的分支 | | |
| | `ONE_OF.SVG_ASSET` | SVG 在 data URI 与独立文件之间自动选择的分支 | |
1 participant
Summary
Expanded and reorganized the list of
ONE_OFchain IDs to include branches for JS, CSS, Less, Sass, Stylus, and SVG, and explained that these are not top-level rules but branches under specific rule types.Related Links
Checklist